Compatibility with Nim v1.6.x, Nim v2.0.x, Nim v2.2.x #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant amount of upstream bugs and regressions have been fixed and backported related to statics, generics and templates which Constantine uses heavily.
This PR works around the last one that prevent Constantine from compiling on devel:
In summary the following cause a type mismatch:
but the following works
However there were 2 template symbol generations issue:
In C, the symbol generated contains invalid backticks like
t`gensym1234
Fortunately, another way to workaround this is to tag the variable as
{.inject.}
which makes the library supported in 1.6.x, 2.0.x and 2.2.x